Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of data types in the R-Instat grid #6266

Closed
rdstern opened this issue Mar 13, 2021 · 3 comments · Fixed by #6288
Closed

Display of data types in the R-Instat grid #6266

rdstern opened this issue Mar 13, 2021 · 3 comments · Fixed by #6288
Assignees
Labels
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Mar 13, 2021

Currently we define some types of data. This could usefully be extended - at least visually in the grid.
For example, from the structured menu, we can define columns to be circular. Then this is noted in the column metadata, but nothing is indicated in the name in the grid.
We can now define columns as survival. This is not noted (currently) in the metadata, nor the grid.
We will have low flow variables etc. there are lots of different ones.
We define dates as D. So far this is for daily data. We have date-time and time coming. How do we show this in the grid.

@volloholic suggestion is simple, and is as follows:
a) We use D - or should it be d for date, or date-time or time. They are all a date-time sort of thing.
b) We use s for structured, so this could be survival, circular, low-flow. It just indicates that it is defined.

Separately to this is that details of the structure, and the type of date is given in the metadata. So that needs to be added for the survival.

This needs @dannyparsons to check. If agreed it needs to be implemented.

If quicker for him to do than explain, then he should. Otherwise he could suggest who implements.

@rdstern rdstern added the Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed label Mar 13, 2021
@rdstern rdstern added this to the 0.7.0 milestone Mar 13, 2021
@rdstern rdstern assigned lloyddewit and unassigned lloyddewit Mar 13, 2021
@rdstern rdstern removed the Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed label Mar 13, 2021
@rdstern rdstern removed this from the 0.7.0 milestone Mar 13, 2021
@rdstern rdstern changed the title Implement the new translation system with default terms Ready for the next suggestion Mar 13, 2021
@rdstern rdstern added this to the 0.6.7 milestone Mar 14, 2021
@rdstern rdstern changed the title Ready for the next suggestion Display of data types in the R-Instat grid Mar 14, 2021
@dannyparsons
Copy link
Contributor

I would prefer different codes for different types of columns. I don't see a problem with users learning a few codes, particularly as they may not use all of them regularly, and only a few will be in a particular dataset.

I feel that the general codes will be less useful and ambiguous, I don't really see an advantage to grouped codes.

@rdstern
Copy link
Collaborator Author

rdstern commented Mar 15, 2021

So, I now know what you don't want!

a) Do you want to keep D for date, or change it to d?
b) What do you want for date-time? Also d or perhaps d_t?
c) And t for time
d) Then are you happy with s for structure, or would you like a different code for each type. So perhaps c for cu=ircular, s for survival, etc

As you can gather, I really don't mind, but would just like us to make a decision!

@rdstern
Copy link
Collaborator Author

rdstern commented Mar 17, 2021

I understand this is now resolved and @dannyparsons will implement.
a) Date variables will continue to be denoted as D. They will be extended, so date time variables and time variables will also be denoted as D in the grid. @dannyparsons will determine how they are shown in the column metadata.
b) Other data types will now change to also have capital letters. In particular, (f) will become (F), and (o.f) will become (O.F). (c) will become (C).
c) Structures for variables will become (S). Currently this is for example for circular data. Later also for time series data.
d) Types of data for specific Application areas will become (A). Initially tis is for survival data, later for low flow data etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants