Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie first help #378

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Cookie first help #378

merged 3 commits into from
Nov 18, 2024

Conversation

LeaSeep
Copy link
Collaborator

@LeaSeep LeaSeep commented Nov 12, 2024

User can now set a cookie; if cookie is set it is remembered and help tab skipped upon next time.
Also option to delete cookie again

PaulJonasJost
PaulJonasJost approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. With the now working shinyjs and added thing to head, we could think of having a separate file for this that is actually a js file?

program/shinyApp/server.R Outdated Show resolved Hide resolved
@LeaSeep @PaulJonasJost
Update program/shinyApp/server.R
9c6559a 
Co-authored-by: Paul Jonas Jost <[email protected]>
@LeaSeep
Copy link
Collaborator Author

LeaSeep commented Nov 15, 2024

yes, agree - opened the issue #400

@LeaSeep LeaSeep merged commit 3fc0186 into develop Nov 18, 2024
1 check passed
@LeaSeep LeaSeep deleted the cookie_firstHelp branch November 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJonasJost PaulJonasJost PaulJonasJost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaSeep @PaulJonasJost