Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org reg agency codelist from org-id.guide #247

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Update org reg agency codelist from org-id.guide #247

merged 2 commits into from
Apr 27, 2018

Conversation

andylolz
Copy link
Contributor

@andylolz andylolz commented Apr 10, 2018

This is a copy and paste of the XML from org-id.guide, to bring the OrganisationRegistrationAgency codelist in line with it.

Refs #235.

@andylolz
Copy link
Contributor Author

andylolz commented Apr 10, 2018

Oh, nice – travis validates codelists against the schema! That is really cool.

I’ve gone back to org-id.guide about the issue: OpenDataServices/org-ids#204

@andylolz
Copy link
Contributor Author

Okay, codelist validates now. Thanks to @timgdavies for the necessary fixes.

@stevieflow
Copy link
Contributor

@amy-silcock @PetyaKangalova @dalepotter are you able to review and merge this PR? It would be great to do this soon, so that the two lists don't differ too much / too quickly

@dalepotter dalepotter requested a review from a team April 27, 2018 10:58
Copy link
Contributor

@amy-silcock amy-silcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are now replicating from Org-ID.guide, happy to approve

@dalepotter dalepotter merged commit fe95c75 into IATI:master Apr 27, 2018
@andylolz andylolz deleted the 235-org-reg-agency branch April 27, 2018 11:05
@andylolz
Copy link
Contributor Author

Great – thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants