Support directional region validation #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc-almeida
approved these changes
Dec 18, 2024
phackstock
requested changes
Dec 19, 2024
danielhuppmann
commented
Dec 19, 2024
|
Thanks @phackstock for the improvement, very nice! I made one minor suggestion to reduce the duplicated validation-statement, feel free to decide whether that should be merged. Over to you to approve. |
phackstock
approved these changes
Dec 19, 2024
danielhuppmann
commented
Dec 19, 2024
There was a problem hiding this comment.
Fair enough @phackstock, but then we can at least make the error messages more specific - what do you think?
Co-authored-by: Daniel Huppmann <[email protected]>
Good point, suggestions are merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements validation for "directional regions" - when defining a region to report e.g. trade flows, this can be implemented as "China>Europe" using a > character. Both the source and the destination have to be defined in the codelist.