Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capacity variables for secondary-energy-carriers #33

Closed

Conversation

danielhuppmann
Copy link
Member

This PR implements capacity-variables in parallel to the "Secondary Energy|..." variable structure.

@danielhuppmann danielhuppmann requested a review from a team November 8, 2023 09:20
@danielhuppmann danielhuppmann self-assigned this Nov 8, 2023
@phackstock phackstock requested review from a team and removed request for a team December 11, 2023 17:58
Copy link
Contributor

@christophbertram christophbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, but two questions:
Should the description for capacity values give an indication of whether gross or net capacity values are preferred?
And for non-electricity secondary energy, it might make sense to specify that this is about the "output" capacity, especially if we keep the unit as "GW" which for example for electrolysers is often the unit specifying the input capacity.

@danielhuppmann
Copy link
Member Author

This was implemented via #177 and #169

@danielhuppmann danielhuppmann deleted the variables/capacity branch October 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants