Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove request account feature #582

Merged
merged 21 commits into from
Nov 25, 2024
Merged

Remove request account feature #582

merged 21 commits into from
Nov 25, 2024

Conversation

ashleysmithTTD
Copy link
Contributor

@ashleysmithTTD ashleysmithTTD commented Nov 21, 2024 •
edited
Loading

Test Plan:

  • check that the login page has no request account link

ashleysmithTTD
ashleysmithTTD commented Nov 21, 2024
View reviewed changes
src/web/screens/dashboard.tsx
@@ -16,7 +16,6 @@ import { ParticipantInformationRoute } from './participantInformation';
import { PortalRoute } from './routeUtils';
import { SharingPermissionsRoute } from './sharingPermissions';
import { TeamMembersRoute } from './teamMembers';
import { TermsOfServiceRoute } from './termsOfService';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This route/screen is no longer needed because terms and conditions is now a dialog that pops up when the user logs in for the first time

@ashleysmithTTD
Copy link
Contributor Author

Besides this code PR, we will also turn off User Registration in keycloak so the user could never access a registration page through a URL

@alex-yau-ttd
Copy link
Contributor

Besides this code PR, we will also turn off User Registration in keycloak so the user could never access a registration page through a URL

I'm hoping this is also do-able via the realm-export.json file. At least they should remain consistent

@ashleysmithTTD
Copy link
Contributor Author

Besides this code PR, we will also turn off User Registration in keycloak so the user could never access a registration page through a URL

I'm hoping this is also do-able via the realm-export.json file. At least they should remain consistent

Oh good call - I need to change registrationAllowed to false in realm-export.json

@ashleysmithTTD ashleysmithTTD merged commit bd9ab2a into main Nov 25, 2024
3 checks passed
@ashleysmithTTD ashleysmithTTD deleted the ans-UID2-4386-remove-request-account-feature branch November 25, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-yau-ttd alex-yau-ttd alex-yau-ttd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleysmithTTD @alex-yau-ttd