Filter out sites from sharing permissions features by using visible
flag
#229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getVisibleSiteList
inadminServiceClient.ts
to callgetSiteList()
then filter out the appropriate sites before returning to the front end.visible==null
to still be included, as that is the default for sites that were created before thevisible
flag was introduced. The default for new sites isvisible==true
getVisibleSiteList
in the base (/
) router and/available
in the sites router. These routes are only used for non-admin functionality and does not break core functionality of the website when the current participant has a site that has visible set to falseManual testing
Given the following sites exist:
We see that
a visible site
shows up in areas of the UI relating to sharing, butan invisible site
does not.The
an invisible site
should still show up in admin areas such as approving participant requests.Other manual testing verified that the functionality of the portal did not break when the user was associated with a site that had
visible==false