Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jyg-UID2-1736 Pretends sharing with DPS when allow_sites is null #200

Closed
wants to merge 6 commits into from
Closed

jyg-UID2-1736 Pretends sharing with DPS when allow_sites is null #200

wants to merge 6 commits into from

Conversation

jingyi-gao-ttd
Copy link
Contributor

@jingyi-gao-ttd jingyi-gao-ttd commented Sep 25, 2023 •
edited
Loading

Changes

  • Decoupling updating sharing type from adding sharing permission endpoint
  • Add new audit trail event for sharing types
  • Set sharedTypes to ['DSP'] to SharingPermissionsTable when allow_sites is null

Manual Tests

Show share with DSP when the participant has completedRecommendations set to true and allow_sites is null

Screenshot 2023-09-25 at 5 23 48 pm Screenshot 2023-09-25 at 5 24 01 pm

Show Recommendation and hide sharingPermissionTable when the participant has completedRecommendations set to false and allow_sites is null

image

When save bulk add permissions should set allow_sites to []

Screen.Recording.2023-09-25.at.5.35.40.pm.mov
image

@jingyi-gao-ttd jingyi-gao-ttd marked this pull request as draft October 5, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-yau-ttd alex-yau-ttd alex-yau-ttd left review comments

@lionell-pack-ttd lionell-pack-ttd lionell-pack-ttd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingyi-gao-ttd @lionell-pack-ttd @alex-yau-ttd