Made eks image smaller #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
reviewed
Jul 24, 2024
| FROM amazonlinux:2023 as full_image | ||
|
|
||
| RUN yum install -y aws-nitro-enclaves-cli && \ | ||
| yum install aws-nitro-enclaves-cli-devel jq -y |
There was a problem hiding this comment.
As @thomasm-ttd mentioned in my last PR aws-nitro-enclaves-cli-devel is probably not needed
There was a problem hiding this comment.
This is amazons recommendation. The later code removes anything we don't need.
There was a problem hiding this comment.
I will see if removing it changes anything.
There was a problem hiding this comment.
I would like to remove it unless we absolutely need it - not from a size thing, but it provides more tools and surface area for compromise on the image than we need.
cYKatherine
reviewed
Jul 24, 2024
| ######## full image ######## | ||
| FROM amazonlinux:2023 as full_image | ||
|
|
||
| RUN yum install -y aws-nitro-enclaves-cli && \ |
There was a problem hiding this comment.
Also let's use dnf instead of yum: https://docs.aws.amazon.com/linux/al2023/ug/package-management.html
thomasm-ttd
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.