jon-UID2-3680-test-coverage-v4-base64-tokens #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnywu
reviewed
Jul 26, 2024
| var tokenAsBinary = UID2Base64UrlCoder.Decode(advertisingTokenBase64Url); | ||
| var advertisingTokenBase64 = Convert.ToBase64String(tokenAsBinary); | ||
| Assert.True(advertisingTokenBase64.Contains("=")); | ||
| Assert.True(advertisingTokenBase64.Contains("/")); |
There was a problem hiding this comment.
there is a slim chance that there may not be / or + char? is it better to assert that advertisingTokenBase64Url must contain - and _ char first (if not, generate a new token value again) and then we are assured that we are testing the Bae64url->base64 conversion with these asserts?
There was a problem hiding this comment.
Added some code to regenerate in a loop until it finds all these base64 chars. Tested a few times, but in practice I've never seen it generate a token that doesn't have all of these chars.
sunnywu
approved these changes
Jul 26, 2024
sunnywu
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.