Address the comments

IABTechLab · Apr 9, 2024 · 48230a6 · 48230a6
1 parent 223cba2
commit 48230a6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/main/java/com/uid2/client/Uid2ClientHelper.java b/src/main/java/com/uid2/client/Uid2ClientHelper.java
@@ -5,7 +5,7 @@
 import java.io.IOException;
 
 public class Uid2ClientHelper {
-    public Uid2ClientHelper(String baseUrl, String clientApiKey) {
+    Uid2ClientHelper(String baseUrl, String clientApiKey) {
         this.baseUrl = baseUrl;
         this.headers = getHeaders(clientApiKey);
     }

diff --git a/src/test/java/com/uid2/client/BidstreamClientTests.java b/src/test/java/com/uid2/client/BidstreamClientTests.java
@@ -276,7 +276,7 @@ private void decryptAndAssertSuccess(String token, TokenVersionForTesting tokenV
         assertSuccess(response, tokenVersion);
     }
 
-    public static void assertSuccess(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
+    static void assertSuccess(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
         assertTrue(response.isSuccess());
         assertEquals(EXAMPLE_UID, response.getUid());
         assertEquals(tokenVersion.ordinal() + 2, response.getAdvertisingTokenVersion());
@@ -286,7 +286,7 @@ public static void assertSuccess(DecryptionResponse response, TokenVersionForTes
         }
     }
 
-    public static void assertFails(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
+    static void assertFails(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
         assertFalse(response.isSuccess());
         assertEquals(DecryptionStatus.INVALID_TOKEN_LIFETIME, response.getStatus());
         assertEquals(tokenVersion.ordinal() + 2, response.getAdvertisingTokenVersion());

diff --git a/src/test/java/com/uid2/client/EncryptionTestsV4.java b/src/test/java/com/uid2/client/EncryptionTestsV4.java
@@ -92,7 +92,7 @@ public void crossPlatformConsistencyCheck_Decrypt() throws Exception {
         assertEquals(EXAMPLE_UID, res.getUid());
     }
 
-    public static void validateAdvertisingToken(String advertisingTokenString, IdentityScope identityScope, IdentityType identityType, TokenVersionForTesting tokenVersion) {
+    static void validateAdvertisingToken(String advertisingTokenString, IdentityScope identityScope, IdentityType identityType, TokenVersionForTesting tokenVersion) {
         if (tokenVersion == TokenVersionForTesting.V2) {
             assertEquals("Ag", advertisingTokenString.substring(0, 2));
             return;

diff --git a/src/test/java/com/uid2/client/SharingClientTests.java b/src/test/java/com/uid2/client/SharingClientTests.java
@@ -75,11 +75,11 @@ private static String keySharingResponse(IdentityScope identityScope, Key... key
         return keySharingResponse(identityScope, null, null, null, keys);
     }
 
-    public static String keySetToJsonForSharing(Key... keys) throws IOException {
+    static String keySetToJsonForSharing(Key... keys) throws IOException {
         return keySharingResponse(IdentityScope.UID2, SITE_ID, 99999, null, keys);
     }
 
-    public static String keySetToJsonForSharing(IdentityScope identityScope, Key... keys) throws IOException {
+    static String keySetToJsonForSharing(IdentityScope identityScope, Key... keys) throws IOException {
         return keySharingResponse(identityScope, SITE_ID, 99999, null, keys);
     }
 
@@ -105,8 +105,6 @@ private void decryptAndAssertSuccess(String advertisingToken, TokenVersionForTes
             "UID2, V4",
             "EUID, V4"
     })
-
-
     public void smokeTest(IdentityScope identityScope, TokenVersionForTesting tokenVersion) throws Exception {
         String advertisingToken = AdvertisingTokenBuilder.builder().withScope(identityScope).withVersion(tokenVersion).build();