-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support for RTL82328 dialect #35
Draft
mrnuke
wants to merge
10
commits into
realtek-poe
Choose a base branch
from
mrnuke-rtl8238b-devel
base: realtek-poe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnuke
force-pushed
the
mrnuke-rtl8238b-devel
branch
from
June 15, 2024 20:14
c916e84
to
c9914a3
Compare
For debug purposes only!
Umh, this may prove to be a very bad idea.
This is wrong. A smart program will automatically detect the dialect, including the baudrate. A buggy program requires the user to correctly configure things. Being stupid takes no effort, so just do it!
The 8-port status command seems, once again, to be specific to engenius devices. Out of about 30 query packets, the 8-port command optimizes out one packet, and is specific to one vendor. That's genius!
mrnuke
force-pushed
the
mrnuke-rtl8238b-devel
branch
from
September 13, 2024 05:22
c9914a3
to
3e5071a
Compare
Apparently, some numbnut at github decided to make the actions versioned. So although we have a perfectly working github pipeline, we need to keep updating it whenever the github powers decide to deprecate a number. So update the "checkout" action from v2, to the diety-approved v4.
mrnuke
force-pushed
the
mrnuke-rtl8238b-devel
branch
from
September 13, 2024 05:32
c2ce0f1
to
c49e44d
Compare
To follow this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS JUST A PROOF OF CONCEPT DO NOT NMERGE THIS!
This PR is for testing purposes only. Bu creating a PR, github should run a pipeline and create an installable package for others to test. That is the purpose of publishing a PR this early in development.
Add initial support for the PoE dialect used by RTL8238B PSE chips.
The original code separation assumed that there would be significant differences in the command structures. I designed the separation interface to be fairly high level, such as:
Many commands are very similar between the the two dialects. The command IDs differ. The original split now menas tha a lot of code is duplicated. I am quite unhappy with the separation.
It is now clear that a better approach is to have common code implementing the dialects, and have a mapping bewteen command and command_id of the dialect.
The flags may seem obscure. Most command dealing with a port number can take more than one (port, value) argument pair. For example
01 <val>02 <val> 03 <val> ff ff
, up to four pairs per command, withff
meaning "nothing to see here. This is the use case for the 4port command function:Other commands can use
7f
as the port ID to configure all ports with the same value:7f <val>
. The flags indialect
map would indicate which commands can use such optimizations.I am hoping that restructuring the code in this manner would reduce duplication, and actually make a PR that makes some sense.