[Halpy-361] Update multiple dispatch commands to be able to use caseIDs and co #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates ``differentiate()`` function to work with single argument commands. - Updates ``lookup, landmark, dssa, diversion`` commands to use ``differentiate()``. - Updates corresponding command help texts.
- Splits the ``differentiate()`` function into two functions, one that actually differentiates a system/cmdr/caseID input and one that handles calls to this function. - Updates relevant commands to use the new ``diff_handler()`` function. - Updates ``Points`` class to make ``point_b`` optional.
Rixxan
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
!diversion,!dssa,!lookupandlandmarkcommands to use thedifferentiate()function for their respective inputs so that users can use those commands with, most notably, case IDs. This change is a significant QoL improvement as it makes gettign this kind of information during cases a lot more convenient.This PR also updates the
differentiate()function to be able to work with just a single provided data point (it was originally designed with it always receiving two in mind).Other Changes:
Closes #361