Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch exceptions when loading particle images #6321

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Catch exceptions when loading particle images #6321

merged 2 commits into from
Oct 13, 2023

Conversation

keianhzo
Copy link
Contributor

Fixes #6316

This PR catches exceptions when loading particle images. It seems that Aframe caught those exceptions as we were are the same thing in the AFrame system.

@keianhzo keianhzo added new-loader P1 Address as quickly as possible labels Oct 12, 2023
takahirox
takahirox approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Nit: We may be able to think of removing ParticleEmitter component if failed. But it's nit and ok to make another PR if the idea sounds good.

@keianhzo
Copy link
Contributor Author

Good idea. Added.

@keianhzo keianhzo merged commit eae3af6 into master Oct 13, 2023
10 of 12 checks passed
@keianhzo keianhzo deleted the bitecs-particle-content-type-fix branch October 13, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirox takahirox takahirox approved these changes

Assignees

@takahirox takahirox

Labels
new-loader P1 Address as quickly as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bitECS - Some scene changes broken with "tried loading multiple nav mesh"
2 participants
@keianhzo @takahirox