Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a comment to explain purpose of overflow wrap in typography.css #490

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

jasonnrosa
Copy link
Member

Types of change

  • Bug fix (change which fixes an issue)
  • Enhancement (change which improves upon an existing feature)
  • New feature (change which adds new functionality)

Description

Adds a couple of comments in the typography.css file to explain the usage of overflow-wrap and direct developers to using a better solution depending on their use case. Also notes the specific CSS for certain languages which can be safely removed if someone doesn't have their site in one of those languages.

Relevant links

Related to this conversation

Checklist

People to notify
CC: @johnsfuller @JacobLett

@jasonnrosa jasonnrosa merged commit aee54a7 into main Aug 10, 2023
@jasonnrosa jasonnrosa deleted the add-comment-word-break branch August 10, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant