introduce model_info type annotation #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to deal w/ some circular imports apparently - standby reviewers! |
Per @pearsonca request fixed GH-396. Cannot type hint the `ModelInfo` objects in `gempyor.initial_conditions/seeding` due to circular imports.
TimothyWillard
force-pushed
the
typing
branch
from
801b5f6
to
aa66077
Compare
pearsonca
commented
Nov 13, 2024
|
@TimothyWillard @jcblemai @emprzy should be passing tests now. This is mainly a type-hinting change, with one change to the NPI class definition to get the ti, tf instead of the whole ModelInfo object. |
pearsonca
pushed a commit
that referenced
this pull request
Nov 13, 2024
Per @pearsonca request fixed GH-396. Cannot type hint the `ModelInfo` objects in `gempyor.initial_conditions/seeding` due to circular imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
This pull request introduces type hints / annotation where model info objects are part of method signatures.
Does this pull request make any user interface changes? If so please describe.
No.
What does your pull request address? Tag relevant issues.
Seems likely this is partial address of some generic software engineering issue.