Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new linkedin api endpoints. #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

qasimgulzar
Copy link

I have added few new linkedin api end points.

comments
JOBS
network
shares
Search Companies
search people
Search Job

Copy link
Collaborator

@reicolina reicolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! 🤘 I added I a couple of comments and a question for you to review. Also, do you think it would be possible to add documentation on how each of the added endpoints/methods works? You could put them in the README.

linkedin_v2/linkedin.py Outdated Show resolved Hide resolved
linkedin_v2/linkedin.py Outdated Show resolved Hide resolved
linkedin_v2/linkedin.py Outdated Show resolved Hide resolved
@reicolina reicolina added the enhancement New feature or request label Sep 22, 2018
Copy link
Collaborator

@reicolina reicolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the suggested modifications 👍One more thing, do you think it would be possible to add documentation for each of the added endpoints/methods? You could put them in the README. You can use the existing profile and connections` descriptions or even the original repo (https://github.com/ozgur/python-linkedin) as a reference point.

This way other developers would be aware of the existence of these endpoints within the library.

Let me know if there are questions or concerns about this suggestion.

Copy link
Collaborator

@reicolina reicolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should now be 0.9.6. Also, would you mind updating the README.md file to reflect the new methods you added. Let me know if you need any help with that.

Thanks again for the work you've done on this PR! 🙌

@@ -1,2 +1,2 @@
__version__ = '0.9.2'
__version__ = '0.9.3'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be 0.9.6

@luiscastillocr
Copy link

do you guys need help to get this out? I would like to help!

I am currently using https://github.com/ozgur/python-linkedin but it seems to be a dead project now

@reicolina
Copy link
Collaborator

do you guys need help to get this out? I would like to help!

I am currently using https://github.com/ozgur/python-linkedin but it seems to be a dead project now

@luiscastillocr, yes absolutely! If you could add the documentation requested to @qasimgulzar in one of my previous comments, that would be great, and will allow us to move forward and merge this PR.

Thanks for you interest and for putting your head up! ✋

@luiscastillocr
Copy link

@reicolina do you want me to create a separated PR to add the documentation? I have no write permissions to @qasimgulzar repo! :/

@reicolina
Copy link
Collaborator

Good point @luiscastillocr. Yes, please go ahead and create a separate PR and post the link to it here so we know that they have to be merged together.

@andronat
Copy link

Hello, any news regarding this? I would love to have it merged 😃

@reicolina
Copy link
Collaborator

Hi @andronat, I’m not an admin anymore so I cannot merge this PR. Perhaps @william-beange-hs can help.

@luiscastillocr
Copy link

oh I am sorry guys, we had to go through the new Linkedin Developer program registration and I am still waiting for approval, I can help with whatever you need to get this merge out as soon as I can put my hands in the V2 api

@s2t2
Copy link

s2t2 commented Jun 27, 2019

oh I am sorry guys, we had to go through the new Linkedin Developer program registration and I am still waiting for approval, I can help with whatever you need to get this merge out as soon as I can put my hands in the V2 api

@luiscastillocr how does one go about applying? I've created an app to get my profile info using this package, but I'd like to also request recommended jobs using the permission "r_JYMBII", but kind of confused as to how to get access.

Thanks! Also hoping you get approved so this PR can be more fully reviewed and merged 😸

@luiscastillocr
Copy link

@s2t2 the submission is still in the review process, I bet there are a lot more people in the same situation because they ended up sending us an email before the deadline to let us know they are extending the V1 access in the meantime they complete the submission review

I quote:

As we approach the previously stated May 1, 2019 migration deadline, if you are currently using our v1.0 APIs, we will extend your v1.0 access until we’ve reviewed your submission and communicated a decision. This means we will continue to support your integration, as we work through the remaining submissions.

I will let you know guys any news

NOTE: if there is anyone can share an account with access to the V2 API, I could use it and help you to get this PR out!

@william-beange-hs
Copy link
Member

Apologies for being absent. Happy to move this along if you'd like to get it in.

@adriangb
Copy link

Any updates on this? It would be great to get this merged.

@luiscastillocr
Copy link

I finally got my account reviewed but I think the PR will need a little more work to get it stable and good to merge, some few things have changed in the LinkedIn API side since this PR was created that was not been considered(endpoint names, changes in the permissions, etc)

But I will be more than happy to get it working!

Any suggestions on how we can proceed? @qasimgulzar

@luiscastillocr
Copy link

if anyone is interested, I've implemented the programmatic refresh tokens along with some few fixes, it is waiting in a PR in the @qasimgulzar repository if he is not interested in contributing to this project anymore, I can just cancel that PR and point it directly to this repo!

thoughts? @reicolina

@qasimgulzar qasimgulzar requested a review from reicolina October 6, 2021 11:50
@luiscastillocr
Copy link

BUMP! @reicolina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants