cordova 7.x upgrades #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes apache#161
The usage of `with` JS statement is highly discouraged for a number of reasons, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with http://www.2ality.com/2011/06/with-statement.html
The problem is "Empty Catch Block", which sonarqube considers a blocker. Added a log message to the empty block. This closes apache#169
This closes apache#94 Signed-off-by: Shazron Abdullah <[email protected]>
This closes apache#176
This closes apache#170
…he app too in addition to closing InAppBrowser
Adds shouldPause feature to stop backgound audio
CSS updated for iframe wrapper in browser platform. Styles and position of wrapper were dependent on parent element, global styles and other elements in body. Now the wrapper/iframe should always cover entire window.
… readme file Github: close apache#163
The intent scheme `intent://` is [recommended by Google ](https://developer.chrome.com/multidevice/android/intents) for launching apps. Cordova should forward this to the OS to handle appropriately. This closes apache#183
The entry is required to protect end-users from fetching edge versions of the plugin by incompatible version of cordova. This also assumes that we will not introduce any regressions in compatibility w/ cordova in minor and patch releases. On every major release we will need to add similar entry with _next_ major version. This closes apache#184
Cordova 6 mods
…ad of an object, aligning it with the other platforms.
This closes apache#228
…rowser and browser implementation
… lists for better developer experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.