Fix date range reset bug

HootsuiteLabs · May 20, 2016 · 26216e8 · 26216e8
1 parent 8137287
commit 26216e8
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/dist/ngDateRange.js b/dist/ngDateRange.js
@@ -46,8 +46,13 @@
         // This will allow us to control the component externally
         scope.$watch('externalModel', function () {
           if (!scope.externalModel.start && !scope.externalModel.end) {
-            // if the model got cleared then reflect that in the view
-            scope.dt = undefined; // null doesn't work!
+            // 'dt' is undefined when loading the component for the first time
+            // so we set it to a falsy vakue to triger the dt 'watch'
+            if (scope.dt === undefined) {
+              scope.dt = null;
+            } else {
+              scope.dt = undefined;
+            }
           }
         });
       }

diff --git a/dist/ngDateRange.min.js b/dist/ngDateRange.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-calendar",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Angular date range picker",
   "main": "app.js",
   "scripts": {

diff --git a/src/ngDateRange.js b/src/ngDateRange.js
@@ -46,8 +46,13 @@
         // This will allow us to control the component externally
         scope.$watch('externalModel', function () {
           if (!scope.externalModel.start && !scope.externalModel.end) {
-            // if the model got cleared then reflect that in the view
-            scope.dt = undefined; // null doesn't work!
+            // 'dt' is undefined when loading the component for the first time
+            // so we set it to a falsy vakue to triger the dt 'watch'
+            if (scope.dt === undefined) {
+              scope.dt = null;
+            } else {
+              scope.dt = undefined;
+            }
           }
         });
       }