Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
The original purpose of gc gen was two fold. The first purpose was to avoid applying the garbage collection results if the store had changed due to multi-process concurrency for any reason. The second purpose was to fast-complete a
dolt gc
invocation if the store had not changed at all since the last GC run.For the first purpose, it is no longer necessary. We no longer allow multi-process access to the same NomsBlockStore.
For the second purpose, it was implemented slightly incorrectly, given the introduction of
dolt gc --full
. This change fixes the implementation to be more correct.In particular, the semantics are:
dolt gc --full
, an immediate invocation ofdolt gc
ordolt gc --full
fast-completes as no collection being necessary.dolt gc
, only adolt gc
fast-completes as no collection being necessary. Adolt gc --full
will run a full GC to completion.go-mysql-server
information_schema.processlist.state
The
State
column in ourinformation_schema.processlist
table is different than the MySQL implementation because we include progress information. As a result, it is possible to exceed the 64 character limit that the column is defined as.However, thius means deviating from MySQL's definition of the table.
Closed Issues