Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab, nbdime: migrate to [email protected] #199649

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Dec 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Dec 1, 2024
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. python-3.13-migration labels Dec 1, 2024
@branchvincent
Copy link
Member

Since these have to be migrated together, we need revision bumps (could also consider removing nbdime's dep on jupyterlab since it doesn't actually depend on it)

This comment was marked as resolved.

@branchvincent branchvincent added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 1, 2024
@chenrui333
Copy link
Member

chenrui333 commented Dec 1, 2024

Since these have to be migrated together, we need revision bumps (could also consider removing nbdime's dep on jupyterlab since it doesn't actually depend on it)

good call 👍 almost forgot.

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 1, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 1, 2024
Merged via the queue into master with commit 6484612 Dec 1, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the jupyterlab_python3.13 branch December 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue python-3.13-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants