Revert "cmake: fix breaking build tree on version/revision bumps"

[akretz]

This reverts #197088 and fixes #198772. The reason for this workaround has been merged upstream into the dev branch already and will be part of the next release #84312 (comment). Not breaking builds has a higher priority than a convenience feature, so I think this patch should be reverted asap.

Also fixes ceres-solver/ceres-solver#1118

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[SMillerDev]

Can we use the patch that was merged upstream instead?

[akretz]

Can we use the patch that was merged upstream instead?

That's possible. I've tried to apply the fix
Kitware/CMake@87cb303...0994bc7
directly on 3.31.1, but it failed with conflicts. So I've resolved them and pushed it onto my fork. I've also had to cherry-pick the helper function
Kitware/CMake@2503b43
which it depends on.

[akretz]

Actually, the upstream patch also fails on my minimal example of #198772, so I removed it again. The interesting thing is that exactly the same patch works when I build CMake not using brew. So right now the situation with regards to that minimal example is

	3.31.1	3.31.1 patched
Build independently	✅	✅
Build brew formula	✅	❌

Probably @carlocab has a better insight on what is going on.

[carlocab]

Actually, the upstream patch also fails on my minimal example of #198772, so I removed it again.

If I'm understanding this correctly: it seems like this needs to be reported upstream then. Because we can revert #197088 now, but that's just going to break again when upstream changes regarding symlink handling land in a CMake release.

Can you try building cmake from their master branch to double-check that you see the problem from #198772 there?