Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luajit 2.1.0-beta3-20230416.4 #128536

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 17, 2023
carlocab
carlocab previously approved these changes Apr 17, 2023
@carlocab
Copy link
Member

  ==> Testing wrk
  ==> /home/linuxbrew/.linuxbrew/Cellar/wrk/4.2.0/bin/wrk -c 1 -t 1 -d 1 https://example.com/
  PANIC: unprotected error in call to Lua API ([string "wrk"]:0: attempt to call field 'lookup' (a nil value))

Probably should be reported to wrk.

@chenrui333
Copy link
Member

logged an issue in here

chenrui333
chenrui333 previously approved these changes Apr 17, 2023
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Apr 17, 2023
@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 19, 2023
@BrewTestBot BrewTestBot dismissed stale reviews from chenrui333 and carlocab via c3a0762 April 19, 2023 22:46
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 19, 2023
Merged via the queue into Homebrew:master with commit 10d25bc Apr 19, 2023
@carlocab
Copy link
Member

We should've waited for a response to wg/wrk#516 here. @chenrui333

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Apr 27, 2023
This was broken in the update to luajit in Homebrew#128536.

I'm not sure why we were in a rush to merge that, but, given that we
did, we should make sure that this formula works until we have a proper
fix.
@carlocab carlocab mentioned this pull request Apr 27, 2023
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants