Merge pull request #199666 from Homebrew/dup-build-testing

formulae: remove duplicate `BUILD_TESTING` arg
Homebrew · Dec 1, 2024 · 937bff1 · 937bff1
2 parents 0f6e541 + 1b034d3
commit 937bff1
Show file tree

Hide file tree

Showing 11 changed files with 18 additions and 25 deletions.
diff --git a/Formula/c/cctz.rb b/Formula/c/cctz.rb
@@ -20,7 +20,7 @@ class Cctz < Formula
   depends_on "cmake" => :build
 
   def install
-    args = ["-DBUILD_TESTING=OFF", "-DCMAKE_POSITION_INDEPENDENT_CODE=ON"]
+    args = ["-DCMAKE_POSITION_INDEPENDENT_CODE=ON"]
 
     system "cmake", "-S", ".", "-B", "build_shared", "-DBUILD_SHARED_LIBS=ON", *args, *std_cmake_args
     system "cmake", "--build", "build_shared"

diff --git a/Formula/c/cnats.rb b/Formula/c/cnats.rb
@@ -21,12 +21,7 @@ class Cnats < Formula
   depends_on "protobuf-c"
 
   def install
-    args = %W[
-      -DCMAKE_INSTALL_PREFIX=#{prefix}
-      -DBUILD_TESTING=OFF
-    ]
-
-    system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
+    system "cmake", "-S", ".", "-B", "build", *std_cmake_args
     system "cmake", "--build", "build"
     system "cmake", "--install", "build"
   end

diff --git a/Formula/c/cryfs.rb b/Formula/c/cryfs.rb
@@ -25,7 +25,6 @@ class Cryfs < Formula
 
   def install
     system "cmake", "-B", "build", "-S", ".",
-                    "-DBUILD_TESTING=off",
                     "-DCRYFS_UPDATE_CHECKS=OFF",
                     "-DDEPENDENCY_CONFIG=cmake-utils/DependenciesFromLocalSystem.cmake",
                     *std_cmake_args

diff --git a/Formula/d/dartsim.rb b/Formula/d/dartsim.rb
@@ -40,19 +40,19 @@ class Dartsim < Formula
   end
 
   def install
-    args = std_cmake_args
+    args = %W[
+      -DCMAKE_INSTALL_RPATH=#{rpath}
+      -DDART_BUILD_DARTPY=OFF
+      -DDART_ENABLE_SIMD=OFF
+    ]
 
     if OS.mac?
       # Force to link to system GLUT (see: https://cmake.org/Bug/view.php?id=16045)
       glut_lib = "#{MacOS.sdk_path}/System/Library/Frameworks/GLUT.framework"
       args << "-DGLUT_glut_LIBRARY=#{glut_lib}"
     end
 
-    args << "-DBUILD_TESTING=OFF"
-    args << "-DDART_BUILD_DARTPY=OFF"
-    args << "-DDART_ENABLE_SIMD=OFF"
-
-    system "cmake", "-S", ".", "-B", "build", "-DCMAKE_INSTALL_RPATH=#{rpath}", *args
+    system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
     system "cmake", "--build", "build"
     system "cmake", "--install", "build"
 

diff --git a/Formula/e/embree.rb b/Formula/e/embree.rb
@@ -28,7 +28,6 @@ class Embree < Formula
 
   def install
     args = %w[
-      -DBUILD_TESTING=OFF
       -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF
       -DEMBREE_ISPC_SUPPORT=ON
       -DEMBREE_TUTORIALS=OFF

diff --git a/Formula/i/inja.rb b/Formula/i/inja.rb
@@ -15,8 +15,7 @@ class Inja < Formula
   depends_on "nlohmann-json"
 
   def install
-    system "cmake", ".", "-DBUILD_TESTING=OFF",
-                         "-DBUILD_BENCHMARK=OFF",
+    system "cmake", ".", "-DBUILD_BENCHMARK=OFF",
                          "-DINJA_USE_EMBEDDED_JSON=OFF",
                          *std_cmake_args
     system "make", "install"

diff --git a/Formula/lib/libchewing.rb b/Formula/lib/libchewing.rb
@@ -25,7 +25,7 @@ class Libchewing < Formula
   end
 
   def install
-    system "cmake", "-S", ".", "-B", "build", "-DBUILD_TESTING=OFF", *std_cmake_args
+    system "cmake", "-S", ".", "-B", "build", *std_cmake_args
     system "cmake", "--build", "build"
     system "cmake", "--install", "build"
   end

diff --git a/Formula/n/netcdf-cxx.rb b/Formula/n/netcdf-cxx.rb
@@ -24,8 +24,12 @@ class NetcdfCxx < Formula
   end
 
   def install
-    args = std_cmake_args + %w[-DBUILD_TESTING=OFF -DNCXX_ENABLE_TESTS=OFF -DENABLE_TESTS=OFF -DENABLE_NETCDF_4=ON
-                               -DENABLE_DOXYGEN=OFF]
+    args = std_cmake_args + %w[
+      -DNCXX_ENABLE_TESTS=OFF
+      -DENABLE_TESTS=OFF
+      -DENABLE_NETCDF_4=ON
+      -DENABLE_DOXYGEN=OFF
+    ]
 
     # https://github.com/Unidata/netcdf-cxx4/issues/151#issuecomment-2041111870
     args << "-DHDF5_C_LIBRARY_hdf5=#{Formula["hdf5"].opt_lib}"

diff --git a/Formula/n/netcdf-fortran.rb b/Formula/n/netcdf-fortran.rb
@@ -21,7 +21,7 @@ class NetcdfFortran < Formula
   depends_on "netcdf"
 
   def install
-    args = std_cmake_args + %w[-DBUILD_TESTING=OFF -DENABLE_TESTS=OFF -DENABLE_NETCDF_4=ON -DENABLE_DOXYGEN=OFF]
+    args = std_cmake_args + %w[-DENABLE_TESTS=OFF -DENABLE_NETCDF_4=ON -DENABLE_DOXYGEN=OFF]
 
     # Help netcdf-fortran find netcf
     # https://github.com/Unidata/netcdf-fortran/issues/301#issuecomment-1183204019

diff --git a/Formula/o/opencl-clhpp-headers.rb b/Formula/o/opencl-clhpp-headers.rb
@@ -17,11 +17,9 @@ class OpenclClhppHeaders < Formula
   depends_on "opencl-headers"
 
   def install
-    system "cmake", "-DBUILD_TESTING=OFF",
+    system "cmake", "-S", ".", "-B", "build",
                     "-DBUILD_DOCS=OFF",
                     "-DBUILD_EXAMPLES=OFF",
-                    "-S", ".",
-                    "-B", "build",
                     *std_cmake_args
     system "cmake", "--build", "build"
     system "cmake", "--install", "build"

diff --git a/Formula/u/uvw.rb b/Formula/u/uvw.rb
@@ -29,7 +29,6 @@ class Uvw < Formula
   def install
     args = %w[
       -DBUILD_UVW_LIBS=ON
-      -DBUILD_TESTING=OFF
       -DBUILD_DOCS=OFF
     ]
     system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args