Skip to content

Commit

Permalink
opencc 1.1.8
Browse files Browse the repository at this point in the history
  • Loading branch information
@daeho-ro
daeho-ro committed Jul 28, 2024
1 parent 6fc877f commit 451cb42
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Formula/o/opencc.rb
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Opencc < Formula
desc "Simplified-traditional Chinese conversion tool"
homepage "https://github.com/BYVoid/OpenCC"
url "https://github.com/BYVoid/OpenCC/archive/refs/tags/ver.1.1.7.tar.gz"
sha256 "80a12675094a0cac90e70ee530e936dc76ca0953cb0443f7283c2b558635e4fe"
url "https://github.com/BYVoid/OpenCC/archive/refs/tags/ver.1.1.8.tar.gz"
sha256 "51693032e702ccc60765b735327d3596df731bf6f426b8ab3580c677905ad7ea"
license "Apache-2.0"

bottle do
Expand Down

5 comments on commit 451cb42

@BYVoid
Copy link
Contributor

@BYVoid BYVoid commented on 451cb42 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is said that the github archives generated from tags are not stable (sha256 sometimes change).
So I created
https://github.com/BYVoid/OpenCC/releases/download/ver.1.1.8/opencc-1.1.8.tar.gz

@daeho-ro
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the manual archive cannot be used here, because when the next version releases, homebrew will try to find 1.1.9 archive also from the manual link form and there not exist.

@gromgit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is said that the github archives generated from tags are not stable (sha256 sometimes change).

Where did you read this? If this is true, the Homebrew maintainers would be very interested, as the majority of formulae use tag URLs for GitHub-hosted source tarballs.

AFAIK, tag archive checksums only change when someone re-tags with a different commit, which the man page for git tag very clearly says is "THE INSANE THING" to do.

@BYVoid
Copy link
Contributor

@BYVoid BYVoid commented on 451cb42 Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the link: https://blog.bazel.build/2023/02/15/github-archive-checksum.html

@gromgit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The article explicitly states that GitHub's own checkin that broke tag archive checksums was rolled back. Also, following one of the linked discussions leads to this comment:

If you had only a tag with no associated release, you should still expect to have a consistent checksum for the archives at /archive/refs/tags/$tag.

In summary: It is safe to reference archives of any kind via the /refs/tags endpoint, everything else enjoys no guarantees.

Please sign in to comment.