Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect download locking. #18809

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Nov 23, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Saw this error here: https://github.com/reitermarkus/dotfiles/actions/runs/11988870070/job/33424635021#step:10:7165

When a download is interrupted at exactly the right time, that is after the LockFile object was created but before the lock file is actually created on disk, the download_lock&.path&.unlink step will fail.

This change ensures the lock/unlock methods themselves are never interrupted, and moves the unlink step into the unlock method as well, so we only remove the lock file if we actually hold the lock.

Also fixes another race condition which may happen if one process deletes a lock file after another already opened it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant