Fix incorrect download locking. #18809
Open
+122
−66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Saw this error here: https://github.com/reitermarkus/dotfiles/actions/runs/11988870070/job/33424635021#step:10:7165
When a download is interrupted at exactly the right time, that is after the
LockFile
object was created but before the lock file is actually created on disk, thedownload_lock&.path&.unlink
step will fail.This change ensures the
lock
/unlock
methods themselves are never interrupted, and moves theunlink
step into theunlock
method as well, so we only remove the lock file if we actually hold the lock.Also fixes another race condition which may happen if one process deletes a lock file after another already opened it.