Use 200ms delay before showing multiview cell edit UI for YT players with allowLiveDvr enabled #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some livestreams have rewind enabled, and clicking on the seek bar on those currently causes the entire seek bar to shift around in the layout (messing with the seek position) due to the multiview button/border popping in as soon as the video is paused. This adds the same delay to lives as VODs such that clicking on the seekbar on live-rewind-enabled YT livestreams seeks to the correct position (dragging is still an unsupported case, for both VODs and lives).
…te check, requiring either not-isLive, or allowLiveDvr
FlaminSarge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some livestreams have rewind enabled, and clicking on the seek bar on those currently causes the entire seek bar to shift around in the layout (messing with the seek position) due to the multiview button/border popping in as soon as the video is paused. This adds the same delay to lives as VODs such that clicking on the seekbar on live-rewind-enabled YT livestreams seeks to the correct position (dragging is still an unsupported case, for both VODs and lives, as the 200ms delay is usually not long enough to drag around in the seekbar before the seekbar shifts upwards due to the border popping in).
This has been updated to only change this behavior if the video has
allowLiveDvrenabled.