Merge pull request #1 from Holicz/upgrade-simple-exception

Update holicz/simple-eception
Holicz · Jan 26, 2021 · 0354f50 · 0354f50
2 parents a6d9909 + 7091132
commit 0354f50
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 21 deletions.
diff --git a/composer.json b/composer.json
@@ -6,7 +6,7 @@
     "require": {
         "php": "^7.4",
         "ext-json": "*",
-        "holicz/simple-exception": "^1.1",
+        "holicz/simple-exception": "^2.0",
         "thecodingmachine/safe": "1.1"
     },
     "require-dev": {

diff --git a/composer.lock b/composer.lock
diff --git a/src/Adapter/PvgisAdapter.php b/src/Adapter/PvgisAdapter.php
@@ -65,7 +65,7 @@ private function parsePvgisResponse(string $response): ElectricityProduction
                 $electricityProduction->addMonthlyProduction($month['month'], $this->multiplier * $month['E_m']);
             }
         } catch (Exception $e) {
-            throw new InvalidResponseFormatException(['response' => $response]);
+            throw new InvalidResponseFormatException();
         }
 
         return $electricityProduction;

diff --git a/src/Exception/InvalidResponseFormatException.php b/src/Exception/InvalidResponseFormatException.php
@@ -11,16 +11,13 @@
 final class InvalidResponseFormatException extends BaseException
 {
     /**
-     * @param array<string, mixed> $parameters
-     *
      * @throws StringsException
      */
-    public function __construct(array $parameters = [])
+    public function __construct()
     {
         $exceptionContext = new ExceptionContext(
             'Nepodařilo se získat informace z evropského Fotovoltaického geografického informačního systému.',
-            \Safe\sprintf('Pvgis responded with unknown format. Response: %s', $parameters['response']),
-            $parameters,
+            \Safe\sprintf('Pvgis responded with unknown format.'),
             500
         );
 

diff --git a/src/Exception/PvgisResponseFailureException.php b/src/Exception/PvgisResponseFailureException.php
@@ -9,15 +9,11 @@
 
 final class PvgisResponseFailureException extends BaseException
 {
-    /**
-     * @param array<string, mixed> $parameters
-     */
-    public function __construct(array $parameters = [])
+    public function __construct()
     {
         $exceptionContext = new ExceptionContext(
             'Nepodařilo se získat informace z evropského Fotovoltaického geografického informačního systému.',
             'Failed to get response from Pvgis API',
-            $parameters,
             500
         );