Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GUI et Icon #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update GUI et Icon #7

wants to merge 3 commits into from

Conversation

SINF-KEN
Copy link

No description provided.

@tdaron
Copy link
Contributor

tdaron commented Dec 9, 2023

There isn't any change for Chrome ? is it intentional ?

@SINF-KEN
Copy link
Author

SINF-KEN commented Dec 9, 2023

yes. Chrome's changes don't concern me - my focus is on maintaining Firefox's superior features and customization options. use firefox.

also didn't test it on chrome, so i won't PR something i don't test.

@Hokkaydo
Copy link
Owner

Hokkaydo commented Dec 9, 2023

yes. Chrome's changes don't concern me - my focus is on maintaining Firefox's superior features and customization options. use firefox.

also didn't test it on chrome, so i won't PR something i don't test.

It would be nice to keep Firefox and Chrome versions aligned.
I'd like you to at least push code that could work. I'll review, test and, if needed, fix it

- removed "webRequestBlocking"
- updated the icon to use the 48px icon 👍
fixed typo in file ( manifest )
updated the popup GUI
@SINF-KEN
Copy link
Author

SINF-KEN commented Dec 9, 2023

Versions should be aligned 🚀

@Hokkaydo
Copy link
Owner

Perfect, thank you very much
I will try both extensions as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants