Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for lat/long coordinate to alphanumeric grid ref #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csmith-he
Copy link
Contributor

Code to fix alphanumeric grid reference generation for lat/long coordinates relating to grid squares that have an easting or northing beginning with 0.

Black formatting has also been applied but the main code changes are to lines (in the new file) 147 - 149 and 171 - 177

@csmith-he csmith-he requested a review from aj-he February 10, 2022 15:52
Copy link
Member

@aj-he aj-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This fix will need to be merged into the v5.x compatible release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants