Skip to content

Commit

Permalink
Ubuntu 24.04の制約を回避するために--no-sandboxオプションをdesktopファイルのExecエントリに追加 (VOI…
Browse files Browse the repository at this point in the history
…CEVOX#2141)

* add --no-sandbox option to linux installer

* add a comment

* fix comment

* Apply suggestions from code review

---------

Co-authored-by: Hiroshiba <[email protected]>
  • Loading branch information
madosuki and Hiroshiba authored Jun 29, 2024
1 parent 9f0132e commit bd99927
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion build/installer_linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ DESKTOP_FILE=$(find squashfs-root -maxdepth 1 -name '*.desktop' | head -1)
chmod +x "${DESKTOP_FILE}"

ESCAPED_APP_DIR=$(echo "$APP_DIR" | sed 's/\//\\\//g')
sed "s/Exec=.*/Exec=${ESCAPED_APP_DIR}\/${APPIMAGE} %U/" "${DESKTOP_FILE}" > _
# TODO: --no-sandboxをつけているのはセキュリティが強化されたUbuntu 24.04で動作させるため ref:https://github.com/electron/electron/issues/41066。外せたら外す。
sed "s/Exec=.*/Exec=${ESCAPED_APP_DIR}\/${APPIMAGE} %U --no-sandbox/" "${DESKTOP_FILE}" > _
mv _ "${DESKTOP_FILE}"

mkdir -p "${DESKTOP_ENTRY_INSTALL_DIR}"
Expand Down

0 comments on commit bd99927

Please sign in to comment.