Merge pull request ballerina-platform#41545 from HindujaB/fix-config-…

…compiler-error Fix throwing unnecessary configurable compilation error
HindujaB · Nov 15, 2023 · 4c27c5c · 4c27c5c
2 parents 57e2a4f + 6a89bf0
commit 4c27c5c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java b/...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
@@ -1156,9 +1156,8 @@ public void visit(BLangSimpleVariable varNode, AnalyzerData data) {
 
         BType lhsType = varNode.symbol.type;
         varNode.setBType(lhsType);
-
         // Configurable variable type must be a subtype of anydata.
-        if (configurable && varNode.typeNode != null) {
+        if (configurable && varNode.typeNode != null && lhsType.tag != TypeTags.SEMANTIC_ERROR) {
             if (!types.isAssignable(lhsType, symTable.anydataType)) {
                 dlog.error(varNode.typeNode.pos,
                         DiagnosticErrorCode.CONFIGURABLE_VARIABLE_MUST_BE_ANYDATA);

diff --git a/...unit-test/src/test/java/org/ballerinalang/test/types/globalvar/GlobalVarNegativeTest.java b/...unit-test/src/test/java/org/ballerinalang/test/types/globalvar/GlobalVarNegativeTest.java
@@ -174,7 +174,7 @@ public void testConfigurableModuleVarDeclNegative() {
         BAssertUtil.validateError(result, i++, "configurable variable currently not supported for " +
                 "'(table<map<()>> & readonly)'\n\t" +
                 "map constraint type '()' is not supported", 106, 1);
-
+        BAssertUtil.validateError(result, i++, "redeclared symbol 'host'", 110, 18);
         Assert.assertEquals(result.getErrorCount(), i);
     }
 

diff --git a/.../test/resources/test-src/statements/variabledef/configurable_global_var_decl_negative.bal b/.../test/resources/test-src/statements/variabledef/configurable_global_var_decl_negative.bal
@@ -104,3 +104,7 @@ configurable string? nilUnion = ?;
 configurable map<()> nilMap = ?;
 configurable Person6 nilRecord1 = ?;
 configurable table<map<()>> nilTable = ?;
+
+// Redeclared configurable variable
+configurable string host = ?;
+configurable int host = ?;