Skip to content

Commit

Permalink
Responded to CRAN Reviwer's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jaehyunjoo committed Apr 22, 2024
1 parent 46a8742 commit 42aba88
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 20 deletions.
4 changes: 2 additions & 2 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 2.1.0
Date: 2024-04-16 21:36:07 UTC
SHA: 491201d962c8c90436a35c36659c292e396941b8
Date: 2024-04-19 16:30:25 UTC
SHA: 46a87420fe5917697dbe94bd9b05e2bc21acd26a
20 changes: 10 additions & 10 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ Authors@R: c(
family = "Himes",
role = c("aut"))
)
Description: This package offers tools to estimate and visualize levels of major
pollutants (CO, NO2, SO2, Ozone, PM2.5 and PM10) across the
conterminous United States for user-defined time ranges. It
provides functions to retrieve pollutant data from the
Environmental Protection Agency’s (EPA) Air Quality System (AQS)
API service for interactive visualization through a 'Shiny'
application, allowing users to explore pollutant levels for a given
location over time relative to the National Ambient Air Quality
Standards (NAAQS).
Description: Offers tools to estimate and visualize levels of major pollutants
(CO, NO2, SO2, Ozone, PM2.5 and PM10) across the conterminous
United States for user-defined time ranges. Provides functions to
retrieve pollutant data from the U.S. Environmental Protection
Agency’s 'Air Quality System' (AQS) API service
<https://aqs.epa.gov/aqsweb/documents/data_api.html> for
interactive visualization through a 'shiny' application, allowing
users to explore pollutant levels for a given location over time
relative to the National Ambient Air Quality Standards (NAAQS).
License: BSD_3_clause + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
Expand All @@ -47,7 +47,7 @@ Imports:
stats,
utils
Depends:
R (>= 4.0.0)
R (>= 4.1.0)
LazyData: true
Suggests:
knitr,
Expand Down
15 changes: 11 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
## Reviewer's comments:

The Description field should not start with the package name, 'This package' or
similar.
Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'Air Quality System' API
Please note that package names are case sensitive. -> 'shiny'

Note that your package is called pargasite, not PARGASITE
- We added single quotes for Air Quality System API
- We changed 'Shiny' -> 'shiny'

- We updated the description field based on reviewer's comment
Please add a web reference for the API in the form <[https:.....]https:.....> to
the description of the DESCRIPTION file with no space after 'https:' and angle
brackets for auto-linking.

- We added a web reference for the API with angle brackets in the DESCRIPTION
file.

## Test environments

Expand Down
2 changes: 1 addition & 1 deletion man/pargasite-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions vignettes/PARGASITE.Rmd
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
title: "Getting Started"
title: "Interactive Visualization of Major Pollutant Levels in the United States"
output: rmarkdown::html_vignette
vignette: >
%\VignetteIndexEntry{Getting Started}
%\VignetteIndexEntry{Interactive Visualization of Major Pollutant Levels in the United States}
%\VignetteEngine{knitr::rmarkdown}
%\VignetteEncoding{UTF-8}
---
Expand Down Expand Up @@ -52,7 +52,7 @@ if (!requireNamespace("raqs", quietly = TRUE)) {
}
library(raqs)
## Please use your eamil address to create an account
## Please use your email address to create an account
## A verification email wille be sent to the eamil account speficied.
aqs_signup('[email protected]')
Expand Down

0 comments on commit 42aba88

Please sign in to comment.