-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTY integration #756
Draft
KernelDeimos
wants to merge
18
commits into
main
Choose a base branch
from
eric/v86-emu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PTY integration #756
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3802e71 - Browse repository at this point
Copy the full SHA 3802e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for b88aa87 - Browse repository at this point
Copy the full SHA b88aa87View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd8fe8f - Browse repository at this point
Copy the full SHA dd8fe8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc6790c - Browse repository at this point
Copy the full SHA cc6790cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68a5b4e - Browse repository at this point
Copy the full SHA 68a5b4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 258b3ca - Browse repository at this point
Copy the full SHA 258b3caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0acd904 - Browse repository at this point
Copy the full SHA 0acd904View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0a79da - Browse repository at this point
Copy the full SHA e0a79daView commit details -
dev: multi-instance many-to-many app-to-app comms
I'll elaborate here because the commit name is confusing. Any time an app gets a connection to another app, either because it launched that app (or was launched by that app) or requested a connection to that app, the ID the app gets to represent the app it's communicating with is now a pseudo app id rather than the app instance ID. This accomplishes two things: 1. It's more secure. There are multiple places where GUI assumes that knowing an app's instance ID means you can do things as that app. 2. Between the same two apps, there may now be more than one connection. This is useful for situations like Phoenix shell talking to the emulator in multiple separate instances to pipe commands. (this is coming later)
Configuration menu - View commit details
-
Copy full SHA for 2e6315e - Browse repository at this point
Copy the full SHA 2e6315eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a16cfb6 - Browse repository at this point
Copy the full SHA a16cfb6View commit details -
dev: add terminal multiplexing
This involves establishing the protocol through which phoenix instances run a command on the emulator. The pty is able to communicate with the terminal in both directions. This commit adds logs to be removed later. There are a few things left that this commit does not address: - handling close of delegate process - handling sigint from phoenix to delegate process - closing the connection to twisp
Configuration menu - View commit details
-
Copy full SHA for d3e70eb - Browse repository at this point
Copy the full SHA d3e70ebView commit details -
Return to phoenix shell when a pty stream is closed by twisp. Pipes in phoenix with commands from the emulator do not appear to be working properly, but something in there is working.
Configuration menu - View commit details
-
Copy full SHA for baeb79b - Browse repository at this point
Copy the full SHA baeb79bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 191977f - Browse repository at this point
Copy the full SHA 191977fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86f2dc4 - Browse repository at this point
Copy the full SHA 86f2dc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c897fd - Browse repository at this point
Copy the full SHA 9c897fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9816411 - Browse repository at this point
Copy the full SHA 9816411View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb2523 - Browse repository at this point
Copy the full SHA dfb2523View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ec3c8b - Browse repository at this point
Copy the full SHA 6ec3c8bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.