Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持 unlisted-versions-of-minecraft #4555

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

支持 unlisted-versions-of-minecraft #4555

wants to merge 33 commits into from

Conversation

zkitefly
Copy link
Collaborator

@zkitefly zkitefly commented Aug 20, 2024 •
edited
Loading

Close #3786

_._20240820174311.mp4

@zkitefly zkitefly marked this pull request as draft August 20, 2024 03:41
@zkitefly zkitefly marked this pull request as ready for review August 20, 2024 03:54
@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 · 优化 🟩 低 优先度：低 labels Aug 20, 2024
@tangge233

This comment was marked as resolved.

Sign in to view
@zkitefly zkitefly marked this pull request as draft August 20, 2024 05:59
@zkitefly
Copy link
Collaborator Author

image 已下载好的版本归类不正确 还有这个 image

image

image

image

版本分类没问题了

@zkitefly zkitefly marked this pull request as ready for review August 20, 2024 08:36
@zkitefly
Copy link
Collaborator Author

image

image

这要解决吗，好像不是本 PR 导致的？

@3gf8jv4dv 3gf8jv4dv mentioned this pull request Sep 23, 2024
Closed
1 task
@3gf8jv4dv

This comment was marked as outdated.

Sign in to view
3gf8jv4dv
3gf8jv4dv approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/zkitefly/unlisted-versions-of-minecraft

Upstream also needs to change to mark versions before 1.0.0 as old.

Other aspects LGTM.

@zkitefly
Copy link
Collaborator Author

https://github.com/zkitefly/unlisted-versions-of-minecraft

Upstream also needs to change to mark versions before 1.0.0 as old.

Other aspects LGTM.

这个标签是 version json 里头的，不是很像改（

tangge233
tangge233 suggested changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@tangge233 tangge233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题不大（）

Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb Outdated Show resolved Hide resolved
@zkitefly
Copy link
Collaborator Author

zkitefly commented Nov 23, 2024 •
edited
Loading

image

排序没问题了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangge233 tangge233 tangge233 requested changes

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv approved these changes

@allMagicNB allMagicNB allMagicNB approved these changes

@LTCatt LTCatt Awaiting requested review from LTCatt

@Deep-Dark-Forest Deep-Dark-Forest Awaiting requested review from Deep-Dark-Forest

Assignees
No one assigned
Labels
· 优化 处理中 开发者正在调查或处理该项 🟩 低 优先度：低
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

支持更多远古版 MC 的下载
8 participants
@zkitefly @tangge233 @wuliaodexiaoluo @allMagicNB @3gf8jv4dv @LTCatt @Deep-Dark-Forest @Pigeon0v0