-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More cmdline options #8
Open
andrew-klaassen
wants to merge
7
commits into
Herschel:master
Choose a base branch
from
andrew-klaassen:more-cmdline-options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
More cmdline options #8
andrew-klaassen
wants to merge
7
commits into
Herschel:master
from
andrew-klaassen:more-cmdline-options
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity with most media players.
Thanks for this! I'm a little busy ATM (we're shipping a game this month!) so I haven't had time to merge these pull requests, but I'll get around to this ASAP. |
No problem. It's working for us: 400 or so renders so far with only a
handful of failures, and we've been able to quickly fix the little problems
that have come up. Hopefully that stays the same for the upcoming 100,000
or so renders. Having the source is fantastic.
I've put some extra commits into my branches that you might not be
interested in; hopefully that doesn't make your merging jobs more
difficult. The last two are for cases where Flash/Animate doesn't follow
the SWF spec about what's allowed in shape versions < 4.
…On 7 February 2018 at 16:33, Mike Welsh ***@***.***> wrote:
Thanks for this! I'm a little busy ATM (we're shipping a game this month!)
so I haven't had time to merge these pull requests, but I'll get around to
this ASAP.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ad3iSBbUC4XP6EHCLRKfgcR9YRVA_VCZks5tShapgaJpZM4RHmjK>
.
--
Andrew
*Andrew Klaassen *- Pipeline TD
23 Fraser Ave, Toronto, Ontario, Canada, M6K1Y7
416.530.9900 x257 | [email protected] |
www.brownbagfilms.com
<https://www.facebook.com/BrownBagFilms/>
<https://twitter.com/BrownBagFilms>
<https://plus.google.com/u/0/b/110245140772518195563/+brownbagfilms>
<https://www.youtube.com/user/brownbagfilms>
9 Story Media Group’s Toronto studio is now Brown Bag Films!
To better serve the needs of our clients, we have rebranded to become one
studio with three locations: Toronto, Dublin and Manchester. 9 Story Media
Group remains the parent company and 9 Story Distribution International is
our distribution division. To learn more about our recent organizational
changes, please visit: Press Release
<http://9story.com/News/NewsDetail?newsID=1889>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a couple of command-line options which we'll be using that would be lovely to have in the master branch.
-png <path/to/namespec_%04d.png>
-k <keyframeEvery> (integer)
The first one is for outputting PNGs (in addition to the MP4). The second one passes through to the "-g" option in ffmpeg; we primarily use it to make the MP4s frame-by-frame scrubbable for animators.
Let me know what you think. Thanks!