Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 modfication page design foodmodifjs #67

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

alecorvec
Copy link
Contributor

@alecorvec alecorvec commented Nov 20, 2024

Describe your changes

Issue ticket number and link

Closes #64

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Documentation has been updated as required
    If a single item in this checklist is not checked, the pull request cannot be accepted

@alecorvec alecorvec self-assigned this Nov 20, 2024
Copy link
Member

@JulesGresset JulesGresset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Circles around button are not perfect round. One way of fixing it is to select a fixed size for the div.
  • We shouldn't be able to select multiple options for the same ingredients
  • Selected modifications doesn't appear on the order

@JulesGresset JulesGresset added the ☀️ Enhancement Better version of a feature already in the project label Nov 28, 2024
@JulesGresset JulesGresset linked an issue Nov 28, 2024 that may be closed by this pull request
@JulesGresset JulesGresset self-requested a review December 16, 2024 20:37
@alecorvec alecorvec merged commit 6e20641 into dev Dec 19, 2024
5 checks passed
@alecorvec alecorvec deleted the 64-modfication-page-design-foodmodifjs branch December 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☀️ Enhancement Better version of a feature already in the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modfication page design FoodModif.js
2 participants