UI Indication for file generation and housekeeping #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the previous logic, when page changed to "downloads", the latest status is not showing
|
AndyRae
reviewed
Dec 11, 2024
AndyRae
approved these changes
Dec 11, 2024
Jivanam
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an indication for file generation in the UI of the
downloadspage when users request a file downloading. This helps increase the UX when using the downloading file function of Carrot.Also, the
update_jobfunction can now handle the scan report's uploading status update. This combination doesn't require any changes in the model and backend.The status icon components across the app are now unified and applied in a cleaner way.
Closes #888
Screenshots