Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny optimisation for better runtime speed #68

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

delahee
Copy link

@delahee delahee commented Oct 1, 2017

Hi,
Very minor but quite good hygiene, feel free to dismiss if a problem.

@Simn
Copy link
Member

Simn commented Oct 1, 2017

CI says there's some problem:

src\hscript\Interp.java:1060: error: incompatible types: StringMap<Object> cannot be converted to StringMap<Hashed>
				haxe.ds.StringMap<hscript._Interp.Hashed> capturedLocals = ((haxe.ds.StringMap<hscript._Interp.Hashed>) (this.duplicate(((haxe.ds.StringMap<hscript._Interp.Hashed>) (this.locals) ))) );
				                                                                                                        ^
src\hscript\Interp_expr_413__Fun.java:109: error: incompatible types: StringMap<Object> cannot be converted to StringMap<Hashed>
		this.me.locals = ((haxe.ds.StringMap<hscript._Interp.Hashed>) (this.me.duplicate(((haxe.ds.StringMap<hscript._Interp.Hashed>) (this.capturedLocals) ))) );
		                                                              ^
2 errors
Compilation error
Native compilation failed
Error: Buil

That's probably some Haxe/Java issue though...

@delahee
Copy link
Author

delahee commented Oct 1, 2017

wow sending a workaround to ci

@delahee
Copy link
Author

delahee commented Oct 1, 2017

hmm okay...I think I can't do anything about that T_T
May be I should file an issue for haxe/java?

@Simn
Copy link
Member

Simn commented Oct 1, 2017

I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants