Adjusted leak

HashLoad · Apr 9, 2019 · abd1277 · abd1277
1 parent e08ee86
commit abd1277
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/src/IDE/Boss.IDE.PojectListener.pas b/src/IDE/Boss.IDE.PojectListener.pas
@@ -25,6 +25,7 @@   TBossProjectListener = class(TNotifierObject, IOTAIDENotifier)
     procedure AddListener(AType: TOTAFileNotification; ACallback: TProc<string>);
     procedure RemoveListener(AType: TOTAFileNotification; ACallback: TProc<string>);
     class function GetInstance: TBossProjectListener;
+    destructor Destroy; override;
   end;
 
 implementation
@@ -74,9 +75,14 @@ constructor TBossProjectListener.Create;
   FListeners := TObjectDictionary < TOTAFileNotification, TList < TProc<string> >>.Create([doOwnsValues]);
 end;
 
-procedure TBossProjectListener.Destroyed;
+destructor TBossProjectListener.Destroy;
 begin
   FListeners.Free;
+  inherited;
+end;
+
+procedure TBossProjectListener.Destroyed;
+begin
 end;
 
 procedure TBossProjectListener.FileNotification(NotifyCode: TOTAFileNotification; const FileName: string;

diff --git a/src/IDE/Boss.IDE.Register.pas b/src/IDE/Boss.IDE.Register.pas
@@ -55,13 +55,12 @@ initialization
 
 finalization
 
-FNotifierMenuIndex := C_INVALID_NOTIFIER;
-
-if FNotifierMenuIndex > C_INVALID_NOTIFIER then
+if FNotifierProjectIndex > C_INVALID_NOTIFIER then
 begin
   (BorlandIDEServices as IOTAServices).RemoveNotifier(FNotifierProjectIndex);
   FNotifierProjectIndex := C_INVALID_NOTIFIER;
 end;
+
 if FNotifierMenuIndex > C_INVALID_NOTIFIER then
 begin
   (BorlandIDEServices as IOTAProjectManager).RemoveMenuItemCreatorNotifier(FNotifierMenuIndex);

diff --git a/src/providers/Providers.Message.pas b/src/providers/Providers.Message.pas
@@ -14,7 +14,6 @@   TProviderMessage = class
     Procedure Initialize(AService: IOTAMessageServices);
     procedure WriteLn(ALine: string);
     procedure Clear;
-    destructor Destroy; override;
 
   end;
 
@@ -28,12 +27,6 @@ procedure TProviderMessage.Clear;
   FService.ClearMessageGroup(FGroup);
 end;
 
-destructor TProviderMessage.Destroy;
-begin
-  FService.RemoveMessageGroup(FGroup);
-  inherited;
-end;
-
 class function TProviderMessage.GetInstance: TProviderMessage;
 begin
   if not Assigned(FInstance) then