Implement parsing of launcher instance files #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed createResourceDirectory running regardless of the "doWriteToResourceTextFile" setting. Code cleanup.
HaXrDEV
changed the title
HaXrDEV
changed the title
HaXrDEV
changed the title
Also removed parseMinecraftInstanceJson config option in favor of making it determined by a prioritized order (BCC > CF > MMC) Moved the checking of which file to parse into its own getFilePath() method. Also added a bespoke error message for when no supported file is found. Also bumped mod version to 2.2.0.
HaXrDEV
changed the title
(Modpack version always returns as Unknown as as the file doesn't actually contain it) Rewrote modpackInfo() & writeResourceTextFile() functions to account for instances where a value doesn't exist or is empty.
… at all Added getJsonValue function allow for getting nested values such as "modpack::version_id".
Also updated changelog. Crashing issue was caused by the saveToFile() function not being correctly injected into. This is due to there being two instances of saveToFile in 1.21 and above. (This never happened when launching the game from IntelliJ)
This was the true culprit of the crashing issue. I wish it didn't take this long for me to figure out xD
According to AzureLib, NeoForge doesn't need to have the refmap specified https://modrinth.com/mod/azurelib/version/eROWkpr4 Also added the refmap line to the mixin file for Forge.
This seems to fix the refmap issue too. Have therefore reverted the fix i had put in previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1
Checklist:
Launchers supported: