-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the show_data function #138
Conversation
Fixes #139 DescriptionDeclaring the variable |
Please review @sandeepsajan0 |
@vedangj044 Can you please run tests and send the screenshots? |
@Guttz please review |
looking fine for me. @Guttz take a look. |
Please Merge |
The count logic that you removed had some very important purpose I don't remember. @Guttz ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xadahiya Yeah I think you are right. I had put it to handle query output which had query execution time and the desired values. But now, I think they have changed the order of output in redisgraph. That's why It might be outdated. As @vedangj044 sends the screenshot of passed tests, I think his approach is working fine. @vedangj044 Can you confirm the changed code is working fine for all the queries/endpoints? Try to run all the possible queries in your local.
Can this be merged? @xadahiya |
@sandeepsajan0 Here are the outputs of |
@sandeepsajan0 @xadahiya do i need to make any other changes ? |
Fixes #137
Checklist
Description
I have changed the show data function in querying_mechanism. Now it outputs similar to the following
[[['id', 36], ['labels', ['collection']], ['properties', [['type', 'MessageCollection'], ['id','vocab:EntryPoint/MessageCollection'], ['operations', "['GET', 'PUT']"]]]]] [[['id', 37], ['labels', ['collection']], ['properties', [['type', 'CommandCollection'], ['id', 'vocab:EntryPoint/CommandCollection'], ['operations', "['GET', 'PUT']"]]]]] [[['id', 38], ['labels', ['collection']], ['properties', [['type', 'StateCollection'], ['id','vocab:EntryPoint/StateCollection'], ['operations', "['GET', 'PUT']"]]]]]
Query internal execution time: 0.903287 milliseconds