Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the show_data function #138

Merged
merged 3 commits into from
May 14, 2020
Merged

Conversation

vedangj044
Copy link
Contributor

Fixes #137

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

I have changed the show data function in querying_mechanism. Now it outputs similar to the following
[[['id', 36], ['labels', ['collection']], ['properties', [['type', 'MessageCollection'], ['id','vocab:EntryPoint/MessageCollection'], ['operations', "['GET', 'PUT']"]]]]] [[['id', 37], ['labels', ['collection']], ['properties', [['type', 'CommandCollection'], ['id', 'vocab:EntryPoint/CommandCollection'], ['operations', "['GET', 'PUT']"]]]]] [[['id', 38], ['labels', ['collection']], ['properties', [['type', 'StateCollection'], ['id','vocab:EntryPoint/StateCollection'], ['operations', "['GET', 'PUT']"]]]]]

Query internal execution time: 0.903287 milliseconds

@vedangj044
Copy link
Contributor Author

Fixes #139

Description

Declaring the variable endpoint_collection_node in collection_endpoint.py in redis_core fixes the bug

@vedangj044
Copy link
Contributor Author

Please review @sandeepsajan0
Thanks !

@sandeepsajan0
Copy link
Contributor

@vedangj044 Can you please run tests and send the screenshots?

@vedangj044
Copy link
Contributor Author

vedangj044 commented Feb 20, 2020

Selection_005
Selection_006
@sandeepsajan0

@xadahiya
Copy link
Member

@Guttz please review

@sandeepsajan0
Copy link
Contributor

looking fine for me. @Guttz take a look.

@vedangj044
Copy link
Contributor Author

Please Merge

@xadahiya
Copy link
Member

xadahiya commented Mar 6, 2020

The count logic that you removed had some very important purpose I don't remember. @Guttz ??

Copy link
Contributor

@sandeepsajan0 sandeepsajan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xadahiya Yeah I think you are right. I had put it to handle query output which had query execution time and the desired values. But now, I think they have changed the order of output in redisgraph. That's why It might be outdated. As @vedangj044 sends the screenshot of passed tests, I think his approach is working fine. @vedangj044 Can you confirm the changed code is working fine for all the queries/endpoints? Try to run all the possible queries in your local.

@chrizandr
Copy link
Member

Can this be merged? @xadahiya

@vedangj044
Copy link
Contributor Author

@sandeepsajan0 Here are the outputs of show endpoints show classEndpoints ``show collectionEndpoints and show StateCollection members queries.
querying_mechanism py — ~-Downloads-learn5-hydra-python-agent — Atom_008
querying_mechanism py — ~-Downloads-learn5-hydra-python-agent — Atom_010

@vedangj044
Copy link
Contributor Author

@sandeepsajan0 @xadahiya do i need to make any other changes ?

@xadahiya xadahiya merged commit f804b0a into HTTP-APIs:develop May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants