Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics package #1710

Merged
merged 49 commits into from
Sep 27, 2024
Merged

Physics package #1710

merged 49 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Add the initial physics package manage dialog 

    Signed-off-by: Brianna Major <[email protected]>
    @bnmajor @psavery
    bnmajor authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8576816 View commit details
    Browse the repository at this point in the history

  2. Move forms into tab widget 

    Signed-off-by: Brianna Major <[email protected]>
    @bnmajor @psavery
    bnmajor authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6bef1ab View commit details
    Browse the repository at this point in the history

  3. Automaically show physics package manager after LLNL import 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b6a1f60 View commit details
    Browse the repository at this point in the history

  4. Include default materials 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5b7bf1c View commit details
    Browse the repository at this point in the history

  5. Use default values 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    063f723 View commit details
    Browse the repository at this point in the history

  6. Save changes to all detectors on accept 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    16d0ff1 View commit details
    Browse the repository at this point in the history

  7. Add selector for physics package type 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d2ced9b View commit details
    Browse the repository at this point in the history

  8. Add option to use physics package to intensity corrections 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5d4d12d View commit details
    Browse the repository at this point in the history

  9. Apply absorption correction when selected in menu 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    79b0e0d View commit details
    Browse the repository at this point in the history

  10. Re-render if physics package changed and absorption correction applied 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c80f1ed View commit details
    Browse the repository at this point in the history

  11. Change pinhole diameter/thickness for PXRDIP 

    The default values are correct for TARDIS.

Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9b2939a View commit details
    Browse the repository at this point in the history

  12. PEP8 fixes 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dc21f06 View commit details
    Browse the repository at this point in the history

  13. Track physics and pinhole package in HexrdConfig 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9aa5c63 View commit details
    Browse the repository at this point in the history

  14. Use pinhole package values in pinhole panel buffer 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9028245 View commit details
    Browse the repository at this point in the history

  15. Use physics package values everywhere 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    66dc814 View commit details
    Browse the repository at this point in the history

  16. Keep values in sync with editor 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    417f40b View commit details
    Browse the repository at this point in the history

  17. Rename NIF laser drive -> laser drive 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4da23a4 View commit details
    Browse the repository at this point in the history

  18. Hide axes 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c390c8c View commit details
    Browse the repository at this point in the history

  19. Decrease num phi elements default: 60 -> 30 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c5007ee View commit details
    Browse the repository at this point in the history

  20. Change readOnly inputs to disabled 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    74d2bbd View commit details
    Browse the repository at this point in the history

  21. Support editing filter, coating and phospohor 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    20eb473 View commit details
    Browse the repository at this point in the history

  22. Use absorption_length from pinhole_package 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5157c32 View commit details
    Browse the repository at this point in the history

  23. Include absorption length in dialog 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0bf36f7 View commit details
    Browse the repository at this point in the history

  24. Update values for PXRDIP even if dialog is not opened 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    afe0093 View commit details
    Browse the repository at this point in the history

  25. PEP8 fixes 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0dc2113 View commit details
    Browse the repository at this point in the history

  26. Add window_materials file 

    Only expect additional material files for window and pinhole.

Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c569a37 View commit details
    Browse the repository at this point in the history

  27. Guess instrument type from detectors 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c264aa5 View commit details
    Browse the repository at this point in the history

  28. Fix package type default 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3da9453 View commit details
    Browse the repository at this point in the history

  29. WIP: Get filter/coating/phosphor defaults 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dd335d1 View commit details
    Browse the repository at this point in the history

  30. Perform subtract minimum last 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6eefdd2 View commit details
    Browse the repository at this point in the history

  31. Correct absorption correction editor title 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    91f915c View commit details
    Browse the repository at this point in the history

  32. Clear material input when not set to "enter manually" 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e4be0a5 View commit details
    Browse the repository at this point in the history

  33. Add phosphor units 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9a419fe View commit details
    Browse the repository at this point in the history

  34. Use recently added return values instead of attribute 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6c652ba View commit details
    Browse the repository at this point in the history

  35. Use pinhole info from physics package 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    934bd7d View commit details
    Browse the repository at this point in the history

  36. Use update functions rather than setters 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    460933c View commit details
    Browse the repository at this point in the history

  37. Physics package is now at instrument level 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b2ca011 View commit details
    Browse the repository at this point in the history

  38. Update default values on instrument change 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    60af650 View commit details
    Browse the repository at this point in the history

  39. Only import config if needed 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c86da4f View commit details
    Browse the repository at this point in the history

  40. Do not make stylesheet changes 

    These do not work well on Mac

Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e3aee3d View commit details
    Browse the repository at this point in the history

  41. Remove unused imports 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    456bb16 View commit details
    Browse the repository at this point in the history

  42. Do not save physics package or coatings to instrument 

    Not all instruments will need a physics package or detector coating information,
so we shouldn't save this information to the instrument. This will prevent
writing out extra information to the config file for users that do not want or
expect it.

Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ea5ec43 View commit details
    Browse the repository at this point in the history

  43. Remember absorption correction setting in state 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    16e047c View commit details
    Browse the repository at this point in the history

  44. Save physics package and detector coatings to state 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d5bbfe1 View commit details
    Browse the repository at this point in the history

  45. Import materials from hexrd resources rather than hexrdgui 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2811a71 View commit details
    Browse the repository at this point in the history

  46. Support instruments with no default physics package 

    Signed-off-by: Brianna Major <[email protected]>
    @psavery
    Brianna Major authored and psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0f3a05a View commit details
    Browse the repository at this point in the history

  47. Go back to pinhole radius for hexrd classes 

    The hexrd classes still expect a pinhole radius. Use that in the check.

Signed-off-by: Patrick Avery <[email protected]>
    @psavery
    psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    68939b3 View commit details
    Browse the repository at this point in the history

  48. Fix detector coatings to accept 'None' from state 

    Otherwise, there are errors...

Signed-off-by: Patrick Avery <[email protected]>
    @psavery
    psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b407b04 View commit details
    Browse the repository at this point in the history

  49. Physics package is now TARDIS/PXRDIP only 

    We are running into trouble using it for other systems. For now,
disable them. We'll add them back in later.

Signed-off-by: Patrick Avery <[email protected]>
    @psavery
    psavery committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    eaffc68 View commit details
    Browse the repository at this point in the history