Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use GaudiAlg #38

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Do not use GaudiAlg #38

merged 4 commits into from
Jul 30, 2024

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jul 29, 2024

These are the changes needed not to use GaudiAlg, which will be removed (maybe soon) in Gaudi.

Changes proposed in this pull-request:

  • Do not link to GaudiAlgLib
  • Add the necessary changes to the algorithm, use Gaudi::Algorithm, make execute() const and add a const EventContext&
  • Add mutable to some elements that are changed; add const to some functions so that they can be called inside execute(const EventContext&) const
  • Change GaudiTool to AlgTool

@jmcarcell
Copy link
Contributor Author

Locally (using the Key4hep nightlies) this builds for me, there doesn't seem to be any ctest tests so I can't run them but behavior should be unchanged.

@jmcarcell
Copy link
Contributor Author

This is another one that would be nice to have merged for building @kjvbrt or @BrieucF (and the last in the batch) I believe.

@BrieucF BrieucF requested a review from SanghyunKo July 30, 2024 13:42
@kjvbrt
Copy link
Contributor

kjvbrt commented Jul 30, 2024

Hi @jmcarcell can you rebase on top of #39 ?

@jmcarcell
Copy link
Contributor Author

Done

@kjvbrt
Copy link
Contributor

kjvbrt commented Jul 30, 2024

Thank you :)

@kjvbrt kjvbrt merged commit 47c8390 into HEP-FCC:master Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants