Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating FCC-ee mH recoil mumu example to work with edm4hep v1 format #400

Merged
merged 13 commits into from
Sep 12, 2024

Conversation

bistapf
Copy link
Contributor

@bistapf bistapf commented Sep 11, 2024

The commits in this PR update the example mH recoil analysis from the FCCSW tutorial to work with the updated edm4hep event data model. Few things to be noted:

  • The updated edm4hep v1 style is only available from setting up the nightlies of key4hep (in current version v00-99, which should already be stable and equivalent towards the official release of v1). Hence the setup script as well as the build&test are adapted to using only the nightlies temporarily and an updated input file.
  • The new tester files in edm4hep v00-99 were produced with k4SimDelphes according to the tutorial and are available in the FCC-hh eos space area and reading the officially produced samples is overwritten in the example.
  • The analysis files as described in the tutorial, section 2.3.1 are added to the respective example directory as well.
  • The plot making step currently does not work out of the box due to problems in do_plots.py to be fixed in PR#397 - otherwise everything should run.
  • This is is a first technically working version for edm4hep v1, whether the more intricate code like getting MC<->Reco relations is still working as intended is to be confirmed.

setup.sh Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@@ -52,4 +52,4 @@ jobs:
docker exec CI_container /bin/bash -c 'cd ./Package; \
source ${{ matrix.STACK }}; \
source ./setup.sh; \
fccanalysis run examples/FCCee/higgs/mH-recoil/mumu/analysis_stage1.py --output myoutput.root --files-list root://eospublic.cern.ch//eos/experiment/fcc/ee/generation/DelphesEvents/spring2021/IDEA/p8_ee_Zbb_ecm91_EvtGen_Bc2TauNuTAUHADNU/events_131527278.root'
fccanalysis run examples/FCCee/higgs/mH-recoil/mumu/analysis_stage1.py --output myoutput.root --test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing ' at the end. So the line should end like this:

--test'

@kjvbrt kjvbrt merged commit 54e8495 into HEP-FCC:master Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants