Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More examples, combine support, BDT/MVA support #368

Merged
merged 2 commits into from
May 13, 2024

Conversation

jeyserma
Copy link
Contributor

  • Added support for BDT/MVA using XGBoost: helper class in Python and C++ added to addons directory
  • Combine support: create Combined datacards from the final stage/histmaker outputs
  • More examples: MVA, Higgs mass/xsec, jet clustering

Will write documentation for all these additions.
We could add these examples to the CI for continuous testing.

Other changes:

  • Added meta info for the final step (similar to histmaker) - xsec, lumi, etc. + fixed optional lumi scaling in the final step
  • wildcard processes for the final step: in case processList is not defined or empty, it looks for all the processes in the input directory
  • RunRDF - change the number of processed events from a DF count rather than sum over events in all files (eventually could remove the count of the number of events in each file - can be time-consuming)

@kjvbrt
Copy link
Contributor

kjvbrt commented May 8, 2024

Nice :)
Can you add a list of commands how to run the whole chain to each of the three examples?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those functions be moved to the analyzers/dataframe ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a major port of all the C++ functions in a subsequent PR (will add some more functions as well).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@kjvbrt kjvbrt merged commit eb96581 into HEP-FCC:pre-edm4hep1 May 13, 2024
4 of 7 checks passed
kjvbrt pushed a commit that referenced this pull request May 13, 2024
* More examples, combine support, BDT/MVA support

* Moved TMVA to addon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants