Make upcoming introduction of cov matrix components transparent #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tmadlener
changed the title
tmadlener
force-pushed
the
edm4hep-cov-matrix
branch
from
7e18133 to
4c19fd4
Compare
|
Removed the WIP and rebased this to pick up newer changes. This is in principle transparent and can go in before the corresponding EDM4hep PR. |
|
Thanks @tmadlener :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key4hep/EDM4hep#287 introduces dedicated covariance matrix components. These are the minimal changes necessary in order to build with current EDM4hep and keep building with the version with covariance matrix components.
Marking this as WIP until we have actually decided whether we want to have the covariance matrix components.