Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add pjax support #135

Merged
merged 15 commits into from
Jul 20, 2021
Merged

[Feature] Add pjax support #135

merged 15 commits into from
Jul 20, 2021

Conversation

HEIGE-PCloud
Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud commented Jul 10, 2021 •
edited
Loading

  • Add pjax support
  • Add top bar
  • Reload functions
  • Update documentation
  • Fix mobile menu switching

@HEIGE-PCloud HEIGE-PCloud self-assigned this Jul 10, 2021
@HEIGE-PCloud HEIGE-PCloud added the enhancement Enhance existing features label Jul 10, 2021
@HEIGE-PCloud HEIGE-PCloud linked an issue Jul 10, 2021 that may be closed by this pull request
[FEATURE] Some feature：支持pjax刷新 #78
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 10, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 522ef22
Status:⚡️  Build in progress...

View logs

@vercel
Copy link

vercel bot commented Jul 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pcloud/do-it/EcLQJwxpZriePsPeGQrdNRxVrjEE
✅ Preview: https://do-it-git-dev-pjax-pcloud.vercel.app

[Deployment for 522ef22 failed]

@HEIGE-PCloud
feat(pjax): fix CSS style
11d95da 
- Change pjax lib
- Fix CSS style
@PaperStrike
Copy link

Since #comments lies inside main, I suggest removing it from the selectors as main is already there.

I also noticed that newly-loaded scripts being executed later than the pjax:success events, this is a bug and you can track the fix in PaperStrike/Pjax#57.

@HEIGE-PCloud HEIGE-PCloud marked this pull request as ready for review July 19, 2021 15:48
@HEIGE-PCloud HEIGE-PCloud merged commit 33243ba into main Jul 20, 2021
@HEIGE-PCloud HEIGE-PCloud deleted the dev/pjax branch July 20, 2021 03:05
@HEIGE-PCloud HEIGE-PCloud mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HEIGE-PCloud HEIGE-PCloud

Labels
enhancement Enhance existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Some feature：支持pjax刷新
2 participants
@HEIGE-PCloud @PaperStrike