ASA-8093 (#142) #143
Merged
ASA-8093 (#142) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handled the URL encoding issue with staging & A360 environment.
mattmurp
reviewed
Feb 28, 2024
There was a problem hiding this comment.
For the 3 urls, is there any reason to create the separate "query" variable? Since the query string is just a hardcoded string, we can replace the spaces with %20 and eliminate the need to call replaceAll(). So in all 3 cases it's simply:
request_url += <the hardcoded query string>
Addressed the PR comments
Sure Matt, Made the changes according to your suggestion. |
mattmurp
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled the URL encoding issue with staging & A360 environment.
This PR also contains the changes for ASA-8145:Meaningful message to be conveyed when Jenkins loses connection to ASoC while scan is in progress.