SCA Support #116
Merged
SCA Support #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vishalhcl-5960
commented
Nov 9, 2023
There was a problem hiding this comment.
Can we create a new class of HttpClient to accomodate the changes required for the support of SCA?
kripajoym
reviewed
Nov 9, 2023
| int status = response.getResponseCode(); | ||
|
|
||
| JSONObject json = (JSONObject) response.getResponseBodyAsJSON(); | ||
|
|
||
| if (status == HttpsURLConnection.HTTP_CREATED) { | ||
| if (status == HttpsURLConnection.HTTP_CREATED || status == 200) { |
There was a problem hiding this comment.
Yeah we have, making the change.
kripajoym
reviewed
Nov 9, 2023
|
|
||
| @Override | ||
| public String getType() { | ||
| return "Sca"; |
There was a problem hiding this comment.
As we were using the "/api/v4/Scans/Sca" API to execute the scan. So, taken the "Sca" from there.
kripajoym
approved these changes
Nov 9, 2023
vishalhcl-5960
added a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira02.hclpnp.com/browse/ASA-6458